summaryrefslogtreecommitdiff
path: root/srv/src/chat/chat.go
blob: 0a88d3b285c4b3d8494270b314e7e312e202c778 (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
// Package chat implements a simple chatroom system.
package chat

import (
	"context"
	"encoding/json"
	"errors"
	"fmt"
	"strconv"
	"sync"
	"time"

	"github.com/mediocregopher/mediocre-go-lib/v2/mctx"
	"github.com/mediocregopher/mediocre-go-lib/v2/mlog"
	"github.com/mediocregopher/radix/v4"
)

// ErrInvalidArg is returned from methods in this package when a call fails due
// to invalid input.
type ErrInvalidArg struct {
	Err error
}

func (e ErrInvalidArg) Error() string {
	return fmt.Sprintf("invalid argument: %v", e.Err)
}

var (
	errInvalidMessageID = ErrInvalidArg{Err: errors.New("invalid Message ID")}
)

// Message describes a message which has been posted to a Room.
type Message struct {
	ID        string `json:"id"`
	UserID    UserID `json:"userID"`
	Body      string `json:"body"`
	CreatedAt int64  `json:"createdAt,omitempty"`
}

func msgFromStreamEntry(entry radix.StreamEntry) (Message, error) {

	// NOTE this should probably be a shortcut in radix
	var bodyStr string
	for _, field := range entry.Fields {
		if field[0] == "json" {
			bodyStr = field[1]
			break
		}
	}

	if bodyStr == "" {
		return Message{}, errors.New("no 'json' field")
	}

	var msg Message
	if err := json.Unmarshal([]byte(bodyStr), &msg); err != nil {
		return Message{}, fmt.Errorf(
			"json unmarshaling body %q: %w", bodyStr, err,
		)
	}

	msg.ID = entry.ID.String()
	msg.CreatedAt = int64(entry.ID.Time / 1000)
	return msg, nil
}

// MessageIterator returns a sequence of Messages which may or may not be
// unbounded.
type MessageIterator interface {

	// Next blocks until it returns the next Message in the sequence, or the
	// context error if the context is cancelled, or io.EOF if the sequence has
	// been exhausted.
	Next(context.Context) (Message, error)

	// Close should always be called once Next has returned an error or the
	// MessageIterator will no longer be used.
	Close() error
}

// HistoryOpts are passed into Room's History method in order to affect its
// result. All fields are optional.
type HistoryOpts struct {
	Limit  int    // defaults to, and is capped at, 100.
	Cursor string // If not given then the most recent Messages are returned.
}

func (o HistoryOpts) sanitize() (HistoryOpts, error) {
	if o.Limit <= 0 || o.Limit > 100 {
		o.Limit = 100
	}

	if o.Cursor != "" {
		id, err := parseStreamEntryID(o.Cursor)
		if err != nil {
			return HistoryOpts{}, fmt.Errorf("parsing Cursor: %w", err)
		}
		o.Cursor = id.String()
	}

	return o, nil
}

// Room implements functionality related to a single, unique chat room.
type Room interface {

	// Append accepts a new Message and stores it at the end of the room's
	// history. The original Message is returned with any relevant fields (e.g.
	// ID) updated.
	Append(context.Context, Message) (Message, error)

	// Returns a cursor and the list of historical Messages in time descending
	// order. The cursor can be passed into the next call to History to receive
	// the next set of Messages.
	History(context.Context, HistoryOpts) (string, []Message, error)

	// Listen returns a MessageIterator which will return all Messages appended
	// to the Room since the given ID. Once all existing messages are iterated
	// through then the MessageIterator will begin blocking until a new Message
	// is posted.
	Listen(ctx context.Context, sinceID string) (MessageIterator, error)

	// Delete deletes a Message from the Room.
	Delete(ctx context.Context, id string) error

	// Close is used to clean up all resources created by the Room.
	Close() error
}

// RoomParams are used to instantiate a new Room. All fields are required unless
// otherwise noted.
type RoomParams struct {
	Logger      *mlog.Logger
	Redis       radix.Client
	ID          string
	MaxMessages int
}

func (p RoomParams) streamKey() string {
	return fmt.Sprintf("chat:{%s}:stream", p.ID)
}

type room struct {
	params RoomParams

	closeCtx    context.Context
	closeCancel context.CancelFunc
	wg          sync.WaitGroup

	listeningL      sync.Mutex
	listening       map[chan Message]struct{}
	listeningLastID radix.StreamEntryID
}

// NewRoom initializes and returns a new Room instance.
func NewRoom(ctx context.Context, params RoomParams) (Room, error) {

	params.Logger = params.Logger.WithNamespace("chat-room")

	r := &room{
		params:    params,
		listening: map[chan Message]struct{}{},
	}

	r.closeCtx, r.closeCancel = context.WithCancel(context.Background())

	// figure out the most recent message, if any.
	lastEntryID, err := r.mostRecentMsgID(ctx)
	if err != nil {
		return nil, fmt.Errorf("discovering most recent entry ID in stream: %w", err)
	}
	r.listeningLastID = lastEntryID

	r.wg.Add(1)
	go func() {
		defer r.wg.Done()
		r.readStreamLoop(r.closeCtx)
	}()

	return r, nil
}

func (r *room) Close() error {
	r.closeCancel()
	r.wg.Wait()
	return nil
}

func (r *room) mostRecentMsgID(ctx context.Context) (radix.StreamEntryID, error) {

	var entries []radix.StreamEntry
	err := r.params.Redis.Do(ctx, radix.Cmd(
		&entries,
		"XREVRANGE", r.params.streamKey(), "+", "-", "COUNT", "1",
	))

	if err != nil || len(entries) == 0 {
		return radix.StreamEntryID{}, err
	}

	return entries[0].ID, nil
}

func (r *room) Append(ctx context.Context, msg Message) (Message, error) {
	msg.ID = "" // just in case

	b, err := json.Marshal(msg)
	if err != nil {
		return Message{}, fmt.Errorf("json marshaling Message: %w", err)
	}

	key := r.params.streamKey()
	maxLen := strconv.Itoa(r.params.MaxMessages)
	body := string(b)

	var id radix.StreamEntryID

	err = r.params.Redis.Do(ctx, radix.Cmd(
		&id, "XADD", key, "MAXLEN", "=", maxLen, "*", "json", body,
	))

	if err != nil {
		return Message{}, fmt.Errorf("posting message to redis: %w", err)
	}

	msg.ID = id.String()
	msg.CreatedAt = int64(id.Time / 1000)
	return msg, nil
}

const zeroCursor = "0-0"

func (r *room) History(ctx context.Context, opts HistoryOpts) (string, []Message, error) {
	opts, err := opts.sanitize()
	if err != nil {
		return "", nil, err
	}

	key := r.params.streamKey()
	end := opts.Cursor
	if end == "" {
		end = "+"
	}
	start := "-"
	count := strconv.Itoa(opts.Limit)

	msgs := make([]Message, 0, opts.Limit)
	streamEntries := make([]radix.StreamEntry, 0, opts.Limit)

	err = r.params.Redis.Do(ctx, radix.Cmd(
		&streamEntries,
		"XREVRANGE", key, end, start, "COUNT", count,
	))

	if err != nil {
		return "", nil, fmt.Errorf("calling XREVRANGE: %w", err)
	}

	var oldestEntryID radix.StreamEntryID

	for _, entry := range streamEntries {
		oldestEntryID = entry.ID

		msg, err := msgFromStreamEntry(entry)
		if err != nil {
			return "", nil, fmt.Errorf(
				"parsing stream entry %q: %w", entry.ID, err,
			)
		}
		msgs = append(msgs, msg)
	}

	if len(msgs) < opts.Limit {
		return zeroCursor, msgs, nil
	}

	cursor := oldestEntryID.Prev()
	return cursor.String(), msgs, nil
}

func (r *room) readStream(ctx context.Context) error {

	r.listeningL.Lock()
	lastEntryID := r.listeningLastID
	r.listeningL.Unlock()

	redisAddr := r.params.Redis.Addr()
	redisConn, err := radix.Dial(ctx, redisAddr.Network(), redisAddr.String())
	if err != nil {
		return fmt.Errorf("creating redis connection: %w", err)
	}
	defer redisConn.Close()

	streamReader := (radix.StreamReaderConfig{}).New(
		redisConn,
		map[string]radix.StreamConfig{
			r.params.streamKey(): {After: lastEntryID},
		},
	)

	for {
		dlCtx, dlCtxCancel := context.WithTimeout(ctx, 10*time.Second)
		_, streamEntry, err := streamReader.Next(dlCtx)
		dlCtxCancel()

		if errors.Is(err, radix.ErrNoStreamEntries) {
			continue
		} else if err != nil {
			return fmt.Errorf("fetching next entry from stream: %w", err)
		}

		msg, err := msgFromStreamEntry(streamEntry)
		if err != nil {
			return fmt.Errorf("parsing stream entry %q: %w", streamEntry, err)
		}

		r.listeningL.Lock()

		var dropped int
		for ch := range r.listening {
			select {
			case ch <- msg:
			default:
				dropped++
			}
		}

		if dropped > 0 {
			ctx := mctx.Annotate(ctx, "msgID", msg.ID, "dropped", dropped)
			r.params.Logger.WarnString(ctx, "some listening channels full, messages dropped")
		}

		r.listeningLastID = streamEntry.ID

		r.listeningL.Unlock()
	}
}

func (r *room) readStreamLoop(ctx context.Context) {
	for {
		err := r.readStream(ctx)
		if errors.Is(err, context.Canceled) {
			return
		} else if err != nil {
			r.params.Logger.Error(ctx, "reading from redis stream", err)
		}
	}
}

type listenMsgIterator struct {
	ch           <-chan Message
	missedMsgs   []Message
	sinceEntryID radix.StreamEntryID
	cleanup      func()
}

func (i *listenMsgIterator) Next(ctx context.Context) (Message, error) {

	if len(i.missedMsgs) > 0 {
		msg := i.missedMsgs[0]
		i.missedMsgs = i.missedMsgs[1:]
		return msg, nil
	}

	for {
		select {
		case <-ctx.Done():
			return Message{}, ctx.Err()
		case msg := <-i.ch:

			entryID, err := parseStreamEntryID(msg.ID)
			if err != nil {
				return Message{}, fmt.Errorf("parsing Message ID %q: %w", msg.ID, err)

			} else if !i.sinceEntryID.Before(entryID) {
				// this can happen if someone Appends a Message at the same time
				// as another calls Listen. The Listener might have already seen
				// the Message by calling History prior to the stream reader
				// having processed it and updating listeningLastID.
				continue
			}

			return msg, nil
		}
	}
}

func (i *listenMsgIterator) Close() error {
	i.cleanup()
	return nil
}

func (r *room) Listen(
	ctx context.Context, sinceID string,
) (
	MessageIterator, error,
) {

	var sinceEntryID radix.StreamEntryID

	if sinceID != "" {
		var err error
		if sinceEntryID, err = parseStreamEntryID(sinceID); err != nil {
			return nil, fmt.Errorf("parsing sinceID: %w", err)
		}
	}

	ch := make(chan Message, 32)

	r.listeningL.Lock()
	lastEntryID := r.listeningLastID
	r.listening[ch] = struct{}{}
	r.listeningL.Unlock()

	cleanup := func() {
		r.listeningL.Lock()
		defer r.listeningL.Unlock()
		delete(r.listening, ch)
	}

	key := r.params.streamKey()
	start := sinceEntryID.Next().String()
	end := "+"
	if lastEntryID != (radix.StreamEntryID{}) {
		end = lastEntryID.String()
	}

	var streamEntries []radix.StreamEntry

	err := r.params.Redis.Do(ctx, radix.Cmd(
		&streamEntries,
		"XRANGE", key, start, end,
	))

	if err != nil {
		cleanup()
		return nil, fmt.Errorf("retrieving missed stream entries: %w", err)
	}

	missedMsgs := make([]Message, len(streamEntries))

	for i := range streamEntries {

		msg, err := msgFromStreamEntry(streamEntries[i])
		if err != nil {
			cleanup()
			return nil, fmt.Errorf(
				"parsing stream entry %q: %w", streamEntries[i].ID, err,
			)
		}

		missedMsgs[i] = msg
	}

	return &listenMsgIterator{
		ch:           ch,
		missedMsgs:   missedMsgs,
		sinceEntryID: sinceEntryID,
		cleanup:      cleanup,
	}, nil
}

func (r *room) Delete(ctx context.Context, id string) error {
	return r.params.Redis.Do(ctx, radix.Cmd(
		nil, "XDEL", r.params.streamKey(), id,
	))
}